-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed the shimmering modifier from OwnerUpgradesView #11683
Conversation
📲 You can test the changes from this Pull Request in WooCommerce iOS by scanning the QR code below to install the corresponding build.
|
Thanks for taking care of this! I have two questions/notes:
|
If I understand the expected behavior that will be enforced in the future correctly p1704280854743209/1704255760.658109-slack-CC7L49W13, we only want to point libraries to a commit and non-commit references won't be allowed after Gio's PR Automattic/dangermattic#30 🤔 I'd think the same principle applies to SPM, but it might be worth double-checking with apps-infra.
Good question, referencing a commit in an un-merged PR might be problematic if they do squash merge or if the author does a force push. It's tricky that we can't use the main branch because of the outstanding issue, maybe we can fork the library (we probably want to check with apps-infra about how to do this so that the forked repo is an A8C repo) and also ping the PR author / library owner about merging this fix and tagging for release. |
Authors PR that is merged is not fully fixing the issue and it looks like the author is not really checking other PRs and issues :/ And he did not even tag that fix with a new version number. Maybe a fork would be the best way of making sure simple packages like this work properly for us. What would be the best solution for us? Maybe we can even write our own shimmer version? |
Thanks for the clarifications @jaclync !
Good question, I don't really have an answer 😅 Since the shimmer is used across multiple views/features let's move the discussion to P2 for a decision. Right now only seems to affect this view, but if the library is sort of abandoned then is certain we'll keep encountering issues as we add more instances of it in the future. For the specific animation oddness that we were trying to fix initially, I'd say that for the time being we can just remove the |
+1 to Gabriel's comment above to p2 the plan to fork the repo / write our own version, and then remove the shimmering modifier for this particular view to fix the issue for now. When we create an issue for the shimmering library change after the plan is finalized, we can add a note about adding the shimmering effect back to this view. |
Tnx @iamgabrielma @jaclync for feedback! I will update this PR according to our comments and write a P2 for continuing the discussion 👍 |
Updated the code and wrote the P2 -> pfoUAQ-7T-p2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking care of this! LGTM 🚢
Closes: #11611
Description
had to use exact commit reference until they merge and tag the proper fixremoved the shimmering modifier from OwnerUpgradesViewThe last commit on SwiftUI-Shimmer main branch still has a bug so I used the commit from unmerged PRTesting instructions
Screenshots
RELEASE-NOTES.txt
if necessary.